Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composable FSDP Transform #987

Open
4 tasks
t-vi opened this issue Aug 18, 2024 · 0 comments
Open
4 tasks

Composable FSDP Transform #987

t-vi opened this issue Aug 18, 2024 · 0 comments
Assignees
Labels

Comments

@t-vi
Copy link
Collaborator

t-vi commented Aug 18, 2024

Make FSDP composable with other transforms.

Desired features:

  • allow FSDPTransform to compose with other transforms (e.g. some Quantization or QLORA),
  • allow FSDPTransform to work with Materialization:
  • as a side condition fsdp(jit(model)) must continue to work as a convenience method for practitioners (thanks @crcrpar for the observation that this should stay simple).

Steps include:

For the side condition of keeping fsdp(jit(model)) working as is, all of these should work while keeping the existing tests unchanged.

@crcrpar @IvanYashchuk (who asked about the plan)

cc @carmocca @crcrpar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant