Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement FSDPTransform.transform_state_dict_for_submodule #989

Merged
merged 11 commits into from
Aug 20, 2024
Merged

implement FSDPTransform.transform_state_dict_for_submodule #989

merged 11 commits into from
Aug 20, 2024

Conversation

t-vi
Copy link
Collaborator

@t-vi t-vi commented Aug 18, 2024

This implements state dict transformation, immediately enabling load_original_state_dict to load an unsharded dictionary into a sharded model.

This is a step in #987 .

(it's ready but relative to #988)

@t-vi t-vi requested a review from crcrpar August 18, 2024 20:18
@t-vi t-vi mentioned this pull request Aug 18, 2024
Open
4 tasks
crcrpar
crcrpar reviewed Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@crcrpar crcrpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so would this happen to indicate that all-gathering sharded state dict is user's responsibility?

thunder/distributed/__init__.py Show resolved Hide resolved
thunder/distributed/__init__.py Show resolved Hide resolved
thunder/distributed/transforms/fsdp_v2.py Outdated Show resolved Hide resolved
@t-vi t-vi force-pushed the tom/fsdp-composable-step2 branch from b663385 to 2357aad Compare August 19, 2024 12:21
@t-vi t-vi force-pushed the tom/fsdp-composable-step3 branch from 4ce64b7 to be3c931 Compare August 19, 2024 12:32
Base automatically changed from tom/fsdp-composable-step2 to main August 19, 2024 14:39
@t-vi t-vi marked this pull request as ready for review August 19, 2024 14:42
@t-vi t-vi requested review from mruberry and lantiga as code owners August 19, 2024 14:42
crcrpar
crcrpar approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@crcrpar crcrpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-vi t-vi merged commit 42e79ba into main Aug 20, 2024
40 checks passed
@t-vi t-vi deleted the tom/fsdp-composable-step3 branch August 20, 2024 08:41
@t-vi
Copy link
Collaborator Author

t-vi commented Aug 20, 2024

Thank you @crcrpar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crcrpar crcrpar crcrpar approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-vi @crcrpar