Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to enable fp8_shard_intermediate_activation #1215

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Add option to enable fp8_shard_intermediate_activation #1215

merged 1 commit into from
Oct 1, 2024

Conversation

crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Sep 30, 2024

What does this PR do?

Adding an option to enable the opt-in feature added by #695

@crcrpar
add option
Loading
Loading status checks…
937b464 
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
@crcrpar crcrpar marked this pull request as ready for review October 1, 2024 05:51
t-vi
t-vi approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have it.

@t-vi t-vi merged commit 69ee6a2 into main Oct 1, 2024
44 checks passed
@t-vi t-vi deleted the crpa/transformerengine_fp8_intermediates_zero3 branch October 1, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi

@mruberry mruberry

@lantiga lantiga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crcrpar @t-vi