Add ThunderFX as a benchmark executor #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardofelluga
requested review from
mruberry,
lantiga and
t-vi
as code owners
IvanYashchuk
reviewed
Oct 7, 2024
t-vi
approved these changes
Oct 15, 2024
Comment on lines
-154
to
+155
| executors = ( | ||
| torch_executor, | ||
| torch_compile_executor, | ||
| thunder_executor, | ||
| ) | ||
| executors = (torch_executor, torch_compile_executor, thunder_executor) |
There was a problem hiding this comment.
What formatter applied this change?
There was a problem hiding this comment.
@IvanYashchuk ruff configured by this
lightning-thunder/pyproject.toml
Line 84 in 40904c7
There was a problem hiding this comment.
I was just curious about this one-line change, usually, a pre-commit job applies changes only to a modified part of the code (at least the one from CI).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
This PR adds ThunderFX in the list of executors in the benchmark suite.