Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match number of backward return values to number of forward args #1300

Merged
merged 1 commit into from
Oct 15, 2024
Merged

match number of backward return values to number of forward args #1300

merged 1 commit into from
Oct 15, 2024

Conversation

crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Oct 15, 2024

The test case lacked None as the last return value

@crcrpar
return None
1a9563f 
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
@t-vi t-vi enabled auto-merge (squash) October 15, 2024 15:23
t-vi
t-vi approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @crcrpar

@t-vi t-vi merged commit 40904c7 into main Oct 15, 2024
41 checks passed
@t-vi t-vi deleted the crpa/fix-custom-autograd-test branch October 15, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crcrpar @t-vi