Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cudagraphs without tensor inputs #1324

Merged
merged 3 commits into from
Oct 18, 2024
Merged

fix cudagraphs without tensor inputs #1324

merged 3 commits into from
Oct 18, 2024

Conversation

t-vi
Copy link
Collaborator

@t-vi t-vi commented Oct 17, 2024

Fixes: #1142

(well fixes the error message hit there. @tfogal do you want this to close the issue or keep it open and update the traceback)

@t-vi t-vi requested review from mruberry and lantiga as code owners October 17, 2024 18:28
@t-vi t-vi mentioned this pull request Oct 17, 2024
Closed
lantiga
lantiga approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped!

@tfogal
Copy link
Collaborator

tfogal commented Oct 17, 2024 •
edited
Loading

Thanks! We can close the related issue; i'll open a new one with a new traceback (if we still hit issues).

@t-vi t-vi enabled auto-merge (squash) October 17, 2024 18:35
@t-vi t-vi merged commit 45bd025 into main Oct 18, 2024
41 checks passed
@t-vi t-vi deleted the tom/cudagraphs-without-tensor-inputs branch October 18, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga lantiga approved these changes

@tfogal tfogal tfogal approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CUDA transform of a NeVA graph
3 participants
@t-vi @tfogal @lantiga