Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rms_norm : relax tolerances #1398

Merged
merged 2 commits into from
Nov 4, 2024
Merged

rms_norm : relax tolerances #1398

merged 2 commits into from
Nov 4, 2024

Conversation

kshitij12345
Copy link
Collaborator

Fixes #1395

@kshitij12345 kshitij12345 marked this pull request as ready for review November 4, 2024 17:04
t-vi
t-vi approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankk you so much!

@t-vi t-vi merged commit cb02f8a into Lightning-AI:main Nov 4, 2024
44 checks passed
@kshitij12345 kshitij12345 deleted the rms_norm-relax-tol branch November 4, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flaky] test_core_vs_torch_consistency_rms_norm is flaky
2 participants
@kshitij12345 @t-vi