Rework timer infrastructure #1410
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfogal
force-pushed
the
tfogal/nvtx
branch
3 times, most recently
from
e6b151f to
2a01e25
Compare
tfogal
changed the title
tfogal
changed the title
tfogal
force-pushed
the
tfogal/nvtx
branch
2 times, most recently
from
9ffb253 to
14418ed
Compare
Add profile annotations to appropriate places. Remove the old timer tracking stuff so that we do not have two methods. Use nsys for proper host profiling.
tfogal
force-pushed
the
tfogal/nvtx
branch
2 times, most recently
from
cbf70f8 to
a427694
Compare
|
This is a follow-up from #1268 (comment), where TomV asked us to just use one method for timing things. Now components just use annotations and it simplifies time tracking. @t-vi @IvanYashchuk this is now ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usable for performance analysis.
Not ready for consideration.