-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[torchao float8tensor] #1415
Draft
crcrpar
wants to merge
101
commits into
main
Choose a base branch
from
crpa/subclass-torchao_float8tensor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[torchao float8tensor] #1415
+1,844
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
crcrpar
force-pushed
the
crpa/subclass-tensor-ops
branch
from
November 19, 2024 06:41
3fa8e2d
to
d5fb9fe
Compare
crcrpar
force-pushed
the
crpa/subclass-torchao_float8tensor
branch
from
November 21, 2024 03:14
abf0167
to
e7ca8b7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
crcrpar
force-pushed
the
crpa/subclass-torchao_float8tensor
branch
2 times, most recently
from
November 24, 2024 16:13
896b631
to
316327f
Compare
@crcrpar if you merge main, the pt nightly distributed ci tests should be fixed. |
crcrpar
force-pushed
the
crpa/subclass-tensor-ops
branch
from
November 26, 2024 07:22
d5fb9fe
to
15c8d12
Compare
crcrpar
force-pushed
the
crpa/subclass-torchao_float8tensor
branch
from
November 26, 2024 07:22
c87a36c
to
0de44ee
Compare
This was referenced Nov 27, 2024
crcrpar
commented
Nov 28, 2024
crcrpar
force-pushed
the
crpa/subclass-tensor-ops
branch
from
November 28, 2024 12:31
15c8d12
to
70dc6ba
Compare
crcrpar
force-pushed
the
crpa/subclass-torchao_float8tensor
branch
from
November 28, 2024 12:32
04d528a
to
804bc99
Compare
crcrpar
commented
Nov 28, 2024
crcrpar
force-pushed
the
crpa/subclass-torchao_float8tensor
branch
from
November 30, 2024 07:02
7c1fea6
to
8475ff7
Compare
crcrpar
force-pushed
the
crpa/subclass-tensor-ops
branch
from
December 7, 2024 07:22
70dc6ba
to
fc6d8a9
Compare
crcrpar
force-pushed
the
crpa/subclass-torchao_float8tensor
branch
2 times, most recently
from
December 9, 2024 09:28
ca3b5f7
to
2b30049
Compare
crcrpar
commented
Dec 11, 2024
crcrpar
force-pushed
the
crpa/subclass-tensor-ops
branch
from
December 12, 2024 23:23
fc6d8a9
to
ce3edbc
Compare
crcrpar
force-pushed
the
crpa/subclass-torchao_float8tensor
branch
from
December 12, 2024 23:25
2b30049
to
6b73636
Compare
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Dec 16, 2024
crcrpar
commented
Dec 16, 2024
thunder/executors/nvfuserex_impl.py
Outdated
Comment on lines
2605
to
2652
scale_a: TensorLike, | ||
scale_b: TensorLike, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to https://github.com/pytorch/ao/blob/200589beb900d4a39a880d4e31b942bed9d31f12/torchao/float8/float8_python_api.py#L22, these would be already inverse scaling factors.
crcrpar
force-pushed
the
crpa/subclass-torchao_float8tensor
branch
from
December 16, 2024 21:48
5fc2dad
to
06d4546
Compare
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
between torch and thunder proxy Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
since the outputs of subclass flattening would be replaceable with the args of ctor/unflatten of that subclass tensors. Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
crcrpar
force-pushed
the
crpa/subclass-torchao_float8tensor
branch
from
December 21, 2024 07:14
33d6a1a
to
fce281b
Compare
due to the inaccurate results compared to `torch._scaled_mm` Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
of tensor subclasses from `nondifferentiable_vjp_symbols` since the trace transform of tensor subclasses comes after VJP Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve the tensor subclass support of #1394 for TorchAo float8.
note: pytorch/ao#1339 is needed
my environment
Traces
Model def
fp32, GELU -> working
Commit: 0893fbe
Model:
bf16, ReLU / GELU -> not working
ReLU -> NVIDIA/Fuser#3609
GELU -> #1567
Commit: 0893fbe
Model: