-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransformerEngine : Add test with FSDP (and updates to ddp_wrapper
in test_ddp.py)
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitij12345
commented
Apr 8, 2024
kshitij12345
changed the title
TransformerEngine : Add test with FSDP (and update to
TransformerEngine : Add test with FSDP (and updates to Apr 8, 2024
ddp_wrapper
in test_ddp.py)ddp_wrapper
in test_ddp.py)
kshitij12345
requested review from
mruberry,
lantiga,
robieta,
t-vi and
carmocca
as code owners
April 9, 2024 08:24
crcrpar
reviewed
Apr 11, 2024
crcrpar
approved these changes
Apr 12, 2024
kshitij12345
commented
Apr 16, 2024
IvanYashchuk
approved these changes
Apr 23, 2024
@carmocca please have a look and stamp the PR, thanks! |
carmocca
approved these changes
Apr 25, 2024
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test for using TE executor in FSDP and verifies it against Eager + TE. Also we update the
ddp_wrapper
to allow wrapping with different pytest-fixture besidesbucket_size_in_mb
(which errored when I tried to add a different pytest-fixture).PR #80 description details of how TE automatically takes care of syncing FP8 meta-data in distributed setting.
Also, I have verified it on a larger model using the available benchmarking script
cmd for benchmark:
Numbers are on RTX 6000
Without TE
With TE