Skip to content

tree_flatten supports named tuples#1446

Merged
t-vi merged 4 commits intomainfrom
alia/namedtuple
Nov 18, 2024
Merged

tree_flatten supports named tuples#1446
t-vi merged 4 commits intomainfrom
alia/namedtuple

Conversation

@ali-alshaar7
Copy link
Copy Markdown
Contributor

@ali-alshaar7 ali-alshaar7 commented Nov 18, 2024

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes (#1442).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ali-alshaar7 ali-alshaar7 changed the title tree_flatten supports subclasses of tuple (named tuples) tree_flatten supports named tuples Nov 18, 2024
@ali-alshaar7 ali-alshaar7 requested a review from crcrpar November 18, 2024 12:10
Copy link
Copy Markdown
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ali-alshaar7

@t-vi t-vi enabled auto-merge (squash) November 18, 2024 12:12
@ali-alshaar7 ali-alshaar7 changed the title tree_flatten supports named tuples tree_flatten supports named tuples Nov 18, 2024
@t-vi
Copy link
Copy Markdown
Collaborator

t-vi commented Nov 18, 2024

CI failure is unrelated.

@t-vi t-vi disabled auto-merge November 18, 2024 13:32
@t-vi t-vi merged commit a5c523d into main Nov 18, 2024
@t-vi t-vi deleted the alia/namedtuple branch November 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants