thunderfx: pass no_grad regions to thunder instead of inductor #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure are real - have opened an issue at NVIDIA/Fuser#3461 |
|
CI with stable PyTorch and older nvFuser is failing (see NVIDIA/Fuser#3461) but the problem has already been fixed (and as can be observed in recent CI run, one with PyTorch nightly and more recent nvfuser is green). Should we update the failing test to skip based on nvfuser version? cc: @IvanYashchuk |
|
Yes, if PyTorch nightly and recent nvFuser CI is passing, please add a skip for an older version. |
|
Looks like a new test is failing now with CI Job for PyTorch night and recent nvFuser. Will have a look. |
4 tasks
|
Ping @IvanYashchuk |
… support-no-grad-thunderfx
…ightning-thunder into support-no-grad-thunderfx
|
Failure looks unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1420