-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docs about adding ops to thunder #149
Conversation
906d12c
to
c4951fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super good! My comments are minor. I don't think there's anything large missing.
For those who are also reviewing, you can see the docs in https://lightning-thunder--149.org.readthedocs.build/en/149/advanced/contrib_thunder.html
cf95a80
to
3e175a0
Compare
3e175a0
to
f694e8c
Compare
Thank you so much, @carmocca , for your review! Let me know if there is something else you would like to point out to! |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Let's merge it and then we can immprove later Thank you @nikitaved @carmocca
As per title.
cc @Borda @apaz-cli