Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs about adding ops to thunder #149

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

nikitaved
Copy link
Contributor

@nikitaved nikitaved commented Apr 9, 2024

As per title.

cc @Borda @apaz-cli

@nikitaved nikitaved added the documentation Improvements or additions to documentation label Apr 9, 2024
@nikitaved nikitaved force-pushed the nikitaved/docs_add_ops_contrib branch 3 times, most recently from 906d12c to c4951fc Compare April 10, 2024 10:43
@nikitaved nikitaved changed the title [WIP] add docs for adding ops add docs about adding ops to thunder Apr 10, 2024
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super good! My comments are minor. I don't think there's anything large missing.

For those who are also reviewing, you can see the docs in https://lightning-thunder--149.org.readthedocs.build/en/149/advanced/contrib_thunder.html

docs/source/advanced/contrib_thunder.rst Outdated Show resolved Hide resolved
docs/source/advanced/contrib_thunder.rst Outdated Show resolved Hide resolved
docs/source/advanced/contrib_thunder.rst Show resolved Hide resolved
docs/source/advanced/contrib_thunder.rst Outdated Show resolved Hide resolved
docs/source/advanced/contrib_thunder.rst Show resolved Hide resolved
docs/source/advanced/contrib_thunder.rst Outdated Show resolved Hide resolved
docs/source/advanced/contrib_thunder.rst Outdated Show resolved Hide resolved
docs/source/advanced/contrib_thunder.rst Outdated Show resolved Hide resolved
docs/source/advanced/contrib_thunder.rst Outdated Show resolved Hide resolved
docs/source/advanced/contrib_thunder.rst Outdated Show resolved Hide resolved
@nikitaved nikitaved force-pushed the nikitaved/docs_add_ops_contrib branch 3 times, most recently from cf95a80 to 3e175a0 Compare April 12, 2024 17:02
@nikitaved nikitaved force-pushed the nikitaved/docs_add_ops_contrib branch from 3e175a0 to f694e8c Compare April 12, 2024 17:02
@nikitaved
Copy link
Contributor Author

nikitaved commented Apr 12, 2024

Thank you so much, @carmocca , for your review! Let me know if there is something else you would like to point out to!

@t-vi t-vi enabled auto-merge (squash) April 12, 2024 17:08
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Let's merge it and then we can immprove later Thank you @nikitaved @carmocca

@t-vi t-vi merged commit 48053fa into main Apr 12, 2024
39 checks passed
@t-vi t-vi deleted the nikitaved/docs_add_ops_contrib branch April 12, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants