Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hardshrink #1505

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Add hardshrink #1505

merged 5 commits into from
Dec 3, 2024

Conversation

beverlylytle
Copy link
Collaborator

@beverlylytle beverlylytle commented Dec 2, 2024 •
edited
Loading

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Add the hardshrink op.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

mruberry
mruberry reviewed Dec 2, 2024
View reviewed changes
thunder/tests/opinfos.py Outdated Show resolved Hide resolved
mruberry
mruberry reviewed Dec 2, 2024
View reviewed changes
thunder/tests/opinfos.py Outdated Show resolved Hide resolved
mruberry
mruberry reviewed Dec 2, 2024
View reviewed changes
thunder/torch/__init__.py Outdated Show resolved Hide resolved
@beverlylytle beverlylytle marked this pull request as ready for review December 3, 2024 17:55
mruberry
mruberry approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry mruberry enabled auto-merge (squash) December 3, 2024 20:24
@mruberry mruberry merged commit a3cdbc4 into main Dec 3, 2024
45 checks passed
@mruberry mruberry deleted the add_hardshrink branch December 3, 2024 20:24
riccardofelluga pushed a commit that referenced this pull request Dec 5, 2024
@beverlylytle @riccardofelluga
Add hardshrink (#1505)
16f45ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry mruberry approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@t-vi t-vi Awaiting requested review from t-vi t-vi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beverlylytle @mruberry