refactor hardshrink_opinfo with singularity_fn_producer #1517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many linear activation functions of torch.nn.functional have partial derivatives with jump discontinuities at dynamically defined values, eg, hardshrink has a kwarg
lambd
which sets the relevant discontinuities at +/-lambd. The testtest_vjp_correctness
relies on using the technique of computing finite differences to approximate these partial derivatives to validate Thunder's computation of the partials. These finite differences behave badly around these discontinuities. Currently, eachOpInfo
allows the supplement of asingularity_fn
to push test input values away from the discontinuities, but it only allows for a singlesingularity_fn
, which cannot reflect the dynamic variation of the "bad" points. This PR introduces asingularity_fn_producer
, which is a function mapping aSampleInput
to asingularity_fn
, allowing thesingularity_fn
to reflect the kwargs of theSampleInput
.