Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the test cases to use thunderfx #1553

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Updates the test cases to use thunderfx #1553

merged 1 commit into from
Dec 13, 2024

Conversation

kiya00
Copy link
Collaborator

@kiya00 kiya00 commented Dec 13, 2024

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

As a follow-up of #1529 , this PR updates the test cases to use new interface thunderfx

Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Maybe in the future we should support using thunderfx as a decorator, like @thunderfx(...), too, but that's not urgent

@mruberry mruberry merged commit 84ba13c into main Dec 13, 2024
41 checks passed
@mruberry mruberry deleted the thunderfx_tests branch December 13, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants