Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip and guard torch.distributed accordingly #1561

Merged
merged 2 commits into from
Dec 17, 2024
Merged

skip and guard torch.distributed accordingly #1561

merged 2 commits into from
Dec 17, 2024
+321 −307

Conversation

crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Dec 17, 2024

What does this PR do?

For environments where torch is built from source with USE_DISTRIBUTED=0 to appropriately skip tests.

@crcrpar
skip and guard accordingly
5bb78e4 
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
@crcrpar crcrpar force-pushed the crpa/skip-dist-test-if-no-dist branch from 38caeba to 5bb78e4 Compare December 17, 2024 11:10
t-vi
t-vi approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @crcrpar

@t-vi t-vi merged commit f7f4f3b into main Dec 17, 2024
41 checks passed
@t-vi t-vi deleted the crpa/skip-dist-test-if-no-dist branch December 17, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crcrpar @t-vi