Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate over fwd_args for hopefully more precise new_fwd_args #1565

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Dec 18, 2024

in the lookaside of torch.ops.higher_order.autograd_function_apply that could take torch.SymInt and/or torch.SymFloat as its arguments passed to GraphModule's forward/backward.

@crcrpar crcrpar requested a review from kiya00 December 18, 2024 07:28
in the lookaside of `torch.ops.higher_order.autograd_function_apply`
that could take `torch.SymInt` and/or `torch.SymFloat` as its arguments
passed to GraphModule's forward/backward.

Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
@crcrpar crcrpar force-pushed the crpa/tryfix1539-graphmodule_dynamic_symint_arg branch from d55e55e to 651366f Compare December 18, 2024 07:32
thunder/core/jit_ext.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kiya00 kiya00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix

@kiya00 kiya00 merged commit c4148ce into tryfix1539 Dec 18, 2024
35 of 37 checks passed
@kiya00 kiya00 deleted the crpa/tryfix1539-graphmodule_dynamic_symint_arg branch December 18, 2024 12:46
kiya00 pushed a commit that referenced this pull request Dec 18, 2024
)

Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants