-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] properly propagate swapped proxies in TraceSubstitutionProcessor
#1632
Conversation
45519f0
to
50b65e2
Compare
Some context on the failures we're running into here:
Remat then continues to assume that these traces are still explicitly linked, which used to be true when |
f7f1bbe
to
6c97c6d
Compare
test propagation using simple buffer casting transform test test propagation using simple buffer casting transform test
handle case of None unpacks in bw_trace svaed_for_backwards tensors
… to the bw from the transformed fw
…_saved_for_backward
ee5d206
to
e30f6f9
Compare
6ddbf7d
to
6e657cc
Compare
12efda3
to
e6e1daa
Compare
86d1ce5
to
2318d64
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ali-alshaar7
Before submitting
What does this PR do?
fixes 1641
the
swap_map
used to replace proxies following substitution transforms did not properly propagate new proxies to other bsyms.PR review
Also adds a test for a simple buffer casting/quantization transform which used to throw key errors.
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃