Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly get parameters with unsharded grads and parameters to register sharded and sync'ed grads #1643

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Correctly get parameters with unsharded grads and parameters to register sharded and sync'ed grads #1643

merged 1 commit into from
Jan 14, 2025

Conversation

crcrpar
Copy link
Collaborator

@crcrpar crcrpar commented Jan 14, 2025

What does this PR do?

Fixes the mismatch described in #1640 (review).

@crcrpar
correctly get parameters
f8fbf6c 
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
@t-vi t-vi merged commit fa8b80c into tom/drop-old-style-distributed Jan 14, 2025
38 of 41 checks passed
@t-vi t-vi deleted the crpa/patch-for-fsdpv2 branch January 14, 2025 07:28
@t-vi
Copy link
Collaborator

t-vi commented Jan 14, 2025

Thank you @crcrpar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry Awaiting requested review from mruberry

@lantiga lantiga Awaiting requested review from lantiga

@t-vi t-vi Awaiting requested review from t-vi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crcrpar @t-vi