Disable enable_saved_for_backward_recomputation path by default #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-vi
requested changes
Jan 18, 2025
There was a problem hiding this comment.
No. We disable the auto-recomputation, which is in the setting of RECOMPUTE_IN_BACKWARD in trace_interpreter.
The enable_saved_for_backward_recomputation flag needs to go as soon as @riccardofelluga does not need it anymore.
Note that enable_saved_for_backward_recomputation is a noop when the option is not given and no tensor has that tag.
Merged
|
I would prefer to have #1661 instead. Does that work for you? |
|
Yes, it works. I didn't know where the code for the pass to be used only for checkpointed operators lives. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's wait a bit before using the changes introduced in #1615 by default. The feature is available by passing
enable_saved_for_backward_recomputation=Trueto thunder.jit.Disabling auto-recomputation as suggested in #1658 (comment).