Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precommit: replace local job with bot #19

Merged
merged 4 commits into from
Mar 21, 2024
Merged

precommit: replace local job with bot #19

merged 4 commits into from
Mar 21, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 20, 2024

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

just to have a more robust check

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda requested review from lantiga and t-vi as code owners March 20, 2024 22:55
@github-actions github-actions bot added the ci label Mar 20, 2024
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Borda

@Borda Borda merged commit e1cdd45 into main Mar 21, 2024
29 of 36 checks passed
@Borda Borda deleted the ci/precommit branch March 21, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants