Replacing uniform with uniform_philox , and incrementing PRNG state#237
Merged
t-vi merged 9 commits intorng_update_primsfrom May 29, 2024
Merged
Replacing uniform with uniform_philox , and incrementing PRNG state#237t-vi merged 9 commits intorng_update_primsfrom
t-vi merged 9 commits intorng_update_primsfrom
Conversation
Collaborator
Author
|
TODO: |
Collaborator
|
Let's split |
4 tasks
Collaborator
Author
|
Hi @mruberry @jjsjann123 @IvanYashchuk , I modified it according our design review discussion, could you take a look? |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
mruberry
approved these changes
May 28, 2024
Collaborator
mruberry
left a comment
There was a problem hiding this comment.
I'll let @IvanYashchuk do the final review. Thanks for the design review, @kiya00!
8 tasks
Collaborator
We had a manual stack here 😃 |
Collaborator
|
Yeah, I'll learn to read... |
Collaborator
Author
|
sorry for the trouble, I should get that draft status on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR is one step towards recomputing dropout in backward, the steps are:
Ref #114