Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: pip install nvFuser for Torch wheels (PR2469) #26

Merged
merged 4 commits into from
Mar 22, 2024
Merged

docker: pip install nvFuser for Torch wheels (PR2469) #26

merged 4 commits into from
Mar 22, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 21, 2024

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

set parity, if Pytoech is installed via pip then also install nvFuser via pip

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda requested review from lantiga, robieta and t-vi as code owners March 21, 2024 10:31
t-vi
t-vi approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Borda

@jjsjann123 fyi

@t-vi t-vi enabled auto-merge (squash) March 22, 2024 13:35
@Borda Borda requested a review from mruberry as a code owner March 22, 2024 14:13
@t-vi t-vi merged commit d385c1b into main Mar 22, 2024
37 of 40 checks passed
@t-vi t-vi deleted the docker/pip-fuser branch March 22, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@robieta robieta Awaiting requested review from robieta

@mruberry mruberry Awaiting requested review from mruberry

Assignees
No one assigned
Labels
docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borda @t-vi