Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: building with Apex (PR2455) #27

Merged
merged 17 commits into from
Mar 27, 2024
Merged

docker: building with Apex (PR2455) #27

merged 17 commits into from
Mar 27, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 21, 2024

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Apex is needed for some of our notebooks
ref: https://github.com/NVIDIA/apex#linux

  • validate docker build with Apex
  • publish updated dockers to be used in CI
  • validate ipynb with Apex -> rm this ipynb from ignore

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda requested a review from mruberry as a code owner March 22, 2024 23:52
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you @Borda

@Borda Borda merged commit 1222864 into main Mar 27, 2024
39 checks passed
@Borda Borda deleted the docker/apex branch March 27, 2024 16:59
@IvanYashchuk
Copy link
Collaborator

Thanks for adding Apex to the build!

There are two tests skipped in this PR that got broken at some point and the skip is valid but without an issue, it's very easy to forget about enabling them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants