Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

triton_ce executor: don't error if triton is not installed (PR2466) #29

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

kshitij12345
Copy link
Collaborator

Similar to nvfuser_ex, we default triton_ex to be None and we register a triton_ex only if triton is available.

@kshitij12345 kshitij12345 marked this pull request as ready for review March 21, 2024 12:11
@carmocca
Copy link
Contributor

carmocca commented Mar 21, 2024

This is great. You should be able to remove

from thunder.executors import triton_crossentropy
and update
actual.discard("triton") # remove when triton can always be imported

@kshitij12345 kshitij12345 requested a review from mruberry as a code owner March 22, 2024 09:57
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Carlos says, this is great. Thank you @kshitij12345 , @carmocca .

@t-vi t-vi merged commit 317dfe5 into Lightning-AI:main Mar 22, 2024
36 checks passed
@github-actions github-actions bot deleted the no-triton-import branch June 22, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants