-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_nested=False #319
Add is_nested=False #319
Conversation
for more information, see https://pre-commit.ci
cc @mruberry: Following your suggestion #93 (comment) that you linked in the original issue, I found out how to do the first half of the suggestion setting is_nested to always False. Could you review and add some suggestions on how to add the second half (ensuring that programs using nestedtensors always fail)? |
This is great, @Fuzzkatt, and I think we can stop this PR here. It does exactly what it should. Failing when provided with a nested tensor can be a separate issue (and should maybe be checked in the prologue, fyi @t-vi). Would you add a test for this property, following the pattern here: lightning-thunder/thunder/tests/opinfos.py Line 548 in 843b2c2
and then let's merge this! |
…htning-thunder into Fuzzkatt/is_nested_temp_fix
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fuzzkatt Looks like this picked up some conflicts that need to be resolved before it's merged |
@t-vi this needs to be merged manually because of flaky ci |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Attempt to fix #287