Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumps cudnnex to 1.2.1 (PR2485) #36

Merged
merged 5 commits into from
Mar 26, 2024
Merged

bumps cudnnex to 1.2.1 (PR2485) #36

merged 5 commits into from
Mar 26, 2024

Conversation

vedaanta
Copy link
Collaborator

What does this PR do?

Bumps cudnn FE version to 1.2.1

@vedaanta vedaanta requested a review from Borda March 21, 2024 17:34
@github-actions github-actions bot added documentation Improvements or additions to documentation ci docker labels Mar 21, 2024
@vedaanta vedaanta added the cudnn label Mar 21, 2024
@Borda Borda self-assigned this Mar 22, 2024
@vedaanta vedaanta requested a review from mruberry as a code owner March 22, 2024 14:17
@Borda
Copy link
Member

Borda commented Mar 22, 2024

just rerun the GPU test in about an hour when the new dockers are updates 🦩

t-vi
t-vi approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vedaanta-nvidia @Borda

@Borda Borda mentioned this pull request Mar 22, 2024
Closed
4 tasks
@vedaanta vedaanta requested a review from carmocca as a code owner March 26, 2024 08:52
@Borda Borda merged commit 1857436 into main Mar 26, 2024
38 checks passed
@Borda Borda deleted the cudnnex/bump branch March 26, 2024 09:31
@wujingyue
Copy link
Collaborator

Great to see the upgrade, Vedaanta! Let me know if you wrote this down somewhere: What does 1.2.1 bring to Thunder? For example, does it fix some disabled tests here?

@vedaanta
Copy link
Collaborator Author

https://github.com/NVIDIA/cudnn-frontend/releases/tag/v1.2.1
1.2.1 was done to fix the way FE finds cudnn_backend(BE) as compared to torch.

On larger note, there is a push going on right now to publish FE on pypi. This required quite a few changes to FE internally. One such change was the dlopen order of BE libs.
1.2.0 broke with thunder CI. more info on this slack thread
Now with the new order of dlopen in 1.2.1, FE integration seems better.

@kshitij12345 kshitij12345 mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@Borda Borda Borda approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@robieta robieta Awaiting requested review from robieta

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@carmocca carmocca Awaiting requested review from carmocca

Assignees

@Borda Borda

Labels
cudnn docker documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vedaanta @Borda @wujingyue @t-vi