Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix rendering of math equations #39

Merged
merged 4 commits into from
Mar 22, 2024
Merged

docs: fix rendering of math equations #39

merged 4 commits into from
Mar 22, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 21, 2024

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

some rendering was off

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda requested review from lantiga, t-vi and robieta as code owners March 21, 2024 18:47
@github-actions github-actions bot added documentation Improvements or additions to documentation ci labels Mar 21, 2024
@Borda Borda requested a review from mruberry as a code owner March 22, 2024 09:28
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Thank you @Borda .

If and when we think it's too slow, we might think about https://pypi.org/project/sphinxcontrib-katex/ .

@t-vi t-vi merged commit 1c91e74 into main Mar 22, 2024
36 checks passed
@t-vi t-vi deleted the docs/math branch March 22, 2024 12:47
@t-vi
Copy link
Collaborator

t-vi commented Mar 22, 2024

Thank you @Borda @wujingyue

@Borda
Copy link
Member Author

Borda commented Mar 22, 2024

If and when we think it's too slow, we might think about pypi.org/project/sphinxcontrib-katex

did not know it, but yes we can check it if we ll face some more difficulties :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants