Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collections.namedtuple: add lookaside #47

Merged
merged 2 commits into from
Mar 25, 2024
Merged

collections.namedtuple: add lookaside #47

merged 2 commits into from
Mar 25, 2024

Conversation

nikitaved
Copy link
Contributor

General jit support for namedtuple types that are being created inside jitted callables.

@nikitaved nikitaved force-pushed the nikitaved/namedtuple_support branch from ea6a1ca to 58ad914 Compare March 22, 2024 13:07
@nikitaved nikitaved force-pushed the nikitaved/namedtuple_support branch from 58ad914 to b79aab5 Compare March 25, 2024 10:36
@nikitaved nikitaved requested a review from carmocca as a code owner March 25, 2024 10:36
@nikitaved nikitaved force-pushed the nikitaved/namedtuple_support branch 3 times, most recently from 18dedec to ad71345 Compare March 25, 2024 11:09
@nikitaved
Copy link
Contributor Author

@t-vi , I have addressed the module issue, thank you for pointing it out! Would you have other comments?

@nikitaved nikitaved force-pushed the nikitaved/namedtuple_support branch 2 times, most recently from 1695701 to 3affdc5 Compare March 25, 2024 14:30
@nikitaved nikitaved force-pushed the nikitaved/namedtuple_support branch from f4cc774 to 87d4c3b Compare March 25, 2024 15:02
t-vi
t-vi approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, seems good to me now. I need to fix the tuple vs. tuple.__new__ by having a new lookaside, but this is the next step.

@t-vi t-vi merged commit 0f03314 into main Mar 25, 2024
36 checks passed
@t-vi t-vi deleted the nikitaved/namedtuple_support branch March 25, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@robieta robieta Awaiting requested review from robieta

@carmocca carmocca Awaiting requested review from carmocca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikitaved @t-vi