jit: support nn.Moudle.named_parameters/buffers #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshitij12345
commented
Jun 27, 2024
t-vi
requested changes
Jun 27, 2024
There was a problem hiding this comment.
@kshitij12345 Absolutely fantastic to work on this!
I think we can solve the duplication by first iterating in the lookaside (directly in Python without proxying / interpreter), keeping the names we get there, and then in the _impl filter...
|
Just wanted to comment that I tried this with NeVA (which is where #601 came from) and the run gets by where we were stopped before! 🎉 |
kshitij12345
commented
Jun 27, 2024
… named-params-and-buffers-jit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #601
As elaborated in the comment, we add lookaside for
Module.named_{parameters/buffers}(for now).