support inferring dtype with torch.get_default_dtype for factory functions #775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #750
Changes -
torch.get_default_dtype
incache_info
. Also, this adds a check to the prologue trace to verify that jitted fn is called with same default dtype - see example prologue below.torch.get_default_dtype
from cache_info (if dtype is not passed explicitly)jitted fn
as reordering and fusion can lead to issue - it is a loud error for now (we can revisit in follow-up if required).Repro:
Prologue Trace
Computation Trace