Skip to content

dict setitem lookaside for module modifications #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

t-vi
Copy link
Collaborator

@t-vi t-vi commented Jul 16, 2024

PT 2.4+ (or 2.5+?) uses dict instead of OrderedDict.

Fixes: #669

@t-vi t-vi requested review from mruberry and lantiga as code owners July 16, 2024 12:14
@t-vi t-vi enabled auto-merge (squash) July 16, 2024 12:16
@t-vi t-vi merged commit 323d7df into main Jul 16, 2024
36 checks passed
@t-vi t-vi deleted the tom/fix_kvcache_669 branch July 16, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failure in thunder/tests/test_jit_general.py::test_litgpt_variants_kvcache with PyTorch 2.5dev
2 participants