Skip to content

Always raise error from the benchmarking script #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 17, 2024
Merged

Always raise error from the benchmarking script #790

merged 5 commits into from
Jul 17, 2024

Conversation

mpatel31415
Copy link
Contributor

@mpatel31415 mpatel31415 commented Jul 17, 2024 •
edited
Loading

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Adds to the benchmark_litgpt.py:

  • Always raising and error from every worker to later catch and manage it.
  • Setting flag TORCH_NCCL_ASYNC_ERROR_HANDLING = 1 to prevent hanging of the benchmarks - it should not impact the performance: info We also tested it for a few cases.
  • Parametrization warmup and max iters

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Yes

@mpatel31415 mpatel31415 marked this pull request as ready for review July 17, 2024 12:20
crcrpar
crcrpar approved these changes Jul 17, 2024
View reviewed changes
t-vi
t-vi approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mpatel31415 @parthmannan @crcrpar

@t-vi t-vi enabled auto-merge (squash) July 17, 2024 17:50
auto-merge was automatically disabled July 17, 2024 19:28

Head branch was pushed to by a user without write access

@t-vi t-vi merged commit 08d8347 into Lightning-AI:main Jul 17, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crcrpar crcrpar crcrpar approved these changes

@t-vi t-vi t-vi approved these changes

@parthmannan parthmannan parthmannan approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpatel31415 @crcrpar @t-vi @parthmannan