Avoid BoundSymbol repeating itself in its subsymbols after functionalization #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitaved
reviewed
Jul 18, 2024
nikitaved
reviewed
Jul 18, 2024
crcrpar
changed the title
crcrpar
force-pushed
the
crpa/no-redundant-bsym-in-subsymbols
branch
2 times, most recently
from
a5bf901 to
4777056
Compare
crcrpar
force-pushed
the
crpa/no-redundant-bsym-in-subsymbols
branch
from
4777056 to
f9c5120
Compare
nikitaved
reviewed
Jul 22, 2024
| @@ -848,6 +848,12 @@ def computation(x): | |||
| new_bsyms.append(new_functional_bsym) | |||
| bsym_inplace_to_functional[new_bsym] = new_functional_bsym | |||
|
|
|||
| if ( | |||
| len(new_functional_bsym.subsymbols) == 1 | |||
| and new_functional_bsym.rhs == new_functional_bsym.subsymbols[0].rhs | |||
There was a problem hiding this comment.
Could you please explain why name/id/other description not involving explicit construction of BoundSymbolRHS is not sufficient? My rationale: I am biased in favor of using as less of hash(BoundSymbol...) as possible...
There was a problem hiding this comment.
I might be just paranoid but I want to make sure args/kwargs are the same, not only sym of them.
crcrpar
force-pushed
the
crpa/no-redundant-bsym-in-subsymbols
branch
from
f9c5120 to
7703887
Compare
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Co-authored-by: nikitaved <nikitaved@users.noreply.github.com> Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
crcrpar
force-pushed
the
crpa/no-redundant-bsym-in-subsymbols
branch
from
7703887 to
fe97811
Compare
|
Thank you @crcrpar @nikitaved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #801.
For some in-place ops, functionalization would create a new boundsymbol whose first subsymbol is identical. As in the linked issue, this redundant nest seems to bother nvfuser region creation. This PR adds a simple check and edit to avoid such situation.