Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase test autocast grad bounds #807

Merged
merged 1 commit into from
Jul 19, 2024
Merged

increase test autocast grad bounds #807

merged 1 commit into from
Jul 19, 2024

Conversation

t-vi
Copy link
Collaborator

@t-vi t-vi commented Jul 19, 2024

The previous bounds were too ambitious, rendering the test flaky.

@t-vi t-vi requested review from mruberry and lantiga as code owners July 19, 2024 05:39
@t-vi t-vi merged commit f75c3ae into main Jul 19, 2024
36 checks passed
@t-vi t-vi deleted the tom/autocast_grad_test_bound branch July 19, 2024 06:37
@t-vi
Copy link
Collaborator Author

t-vi commented Jul 19, 2024

Thank you @crcrpar for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crcrpar crcrpar crcrpar approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-vi @crcrpar