Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_autocast_torch_matmul: fix flakiness #851

Merged
merged 1 commit into from
Jul 24, 2024
Merged

test_autocast_torch_matmul: fix flakiness #851

merged 1 commit into from
Jul 24, 2024

Conversation

nikitaved
Copy link
Contributor

Fixes #850.

Passes the following:

pytest --show-progress --verbose thunder/tests/test_autocast.py -k test_autocast_torch_matmul --count 10000 -n 30
...
__________________________________________________________________________ 80000 of 80000 completed, 80000 Pass, 0 Fail, 0 Skip, 0 XPass, 0 XFail, 0 Error, 0 ReRun __________________________________________________________________________

@nikitaved nikitaved requested a review from kshitij12345 July 24, 2024 10:33
kshitij12345
kshitij12345 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@kshitij12345 kshitij12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (especially with 10000 runs), thanks @nikitaved

@kshitij12345
Copy link
Collaborator

Have created an issue for the failing test test_change_default_device_with_ctx - #853

@t-vi t-vi enabled auto-merge (squash) July 24, 2024 13:41
t-vi
t-vi approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nikitaved @kshitij12345

@t-vi t-vi disabled auto-merge July 24, 2024 13:42
@t-vi t-vi merged commit 1c59321 into main Jul 24, 2024
35 of 37 checks passed
@t-vi t-vi deleted the nikitaved/autocast_matmul_fix_flaky_test branch July 24, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@kshitij12345 kshitij12345 kshitij12345 approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_autocast_matmul: is flaky
3 participants
@nikitaved @kshitij12345 @t-vi