Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: testing with torch==2.3 /test and move 2.4 /nightly #86

Merged
merged 11 commits into from
Mar 30, 2024
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 27, 2024

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

As 2.3 branch was already cut https://github.com/pytorch/pytorch/tree/release/2.3
and Meta is building dev versions; we will switch to using proper versions

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda requested a review from robieta as a code owner March 27, 2024 11:17
@Borda Borda requested a review from tfogal March 29, 2024 09:30
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, thannk you @Borda

@Borda Borda merged commit 926121c into main Mar 30, 2024
42 checks passed
@Borda Borda deleted the ci/torch-2.3 branch March 30, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants