Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure multiple tensors are passed to pack_for_fsdp #87

Merged
merged 1 commit into from
Mar 27, 2024
Merged

make sure multiple tensors are passed to pack_for_fsdp #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions thunder/tests/distributed/test_ddp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,6 +693,24 @@ def test_fsdp_grad_parity_with_without_bucketing(
self.assertEqual(loss, orig_loss)
self.assertEqual(tuple(p.grad for p in cm.parameters() if p.grad is not None), gradients)

# Make sure that at least one of "pack" takes multiple tensors.
from thunder.executors.torchex import pack_for_fsdp_prim_impl
from thunder.distributed.prims import PrimIDs as DistPrimIDs

for ex_trace in (thunder.last_traces(cm)[-1], thunder.last_backward_traces(cm)[-1]):
pack_bsyms = list(
filter(
lambda bsym: bsym.sym.id in {DistPrimIDs.PACK_FOR_FSDP, pack_for_fsdp_prim_impl.id},
carmocca marked this conversation as resolved.
Show resolved Hide resolved
ex_trace.bound_symbols,
)
)
has_pack_multiple_tensors = False
for bsym in pack_bsyms:
first_arg = bsym.args[0]
self.assertIsInstance(first_arg, list)
has_pack_multiple_tensors |= len(first_arg) > 1
self.assertTrue(has_pack_multiple_tensors, msg=f"{[bsym.args[0] for bsym in pack_bsyms]=}")

@pytest.mark.skipif(torch.cuda.device_count() < 2, reason="Requires 2 devices")
def test_fsdp_shard_unshard(self):
from thunder.distributed import _shard_params, _unshard_params
Expand Down
Loading