Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove transform_trace_additionally #914

Merged
merged 18 commits into from
Aug 20, 2024
Merged

remove transform_trace_additionally #914

merged 18 commits into from
Aug 20, 2024

Conversation

k223kim
Copy link
Contributor

@k223kim k223kim commented Aug 2, 2024 •
edited
Loading

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

partially fixes #640.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

⚡️

@k223kim k223kim marked this pull request as ready for review August 5, 2024 08:06
@k223kim k223kim marked this pull request as draft August 5, 2024 16:45
@k223kim k223kim force-pushed the k223kim/remove_transform_trace_additionally branch from 391ab64 to 0e32bac Compare August 6, 2024 07:06
@t-vi t-vi self-assigned this Aug 9, 2024
t-vi
t-vi reviewed Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @k223kim . Great! The old transform hook is almost gone. 🚀
I left a few comments regarding and in addition to what we discussed on slack.

thunder/__init__.py Outdated Show resolved Hide resolved
thunder/core/transforms.py Show resolved Hide resolved
thunder/core/transforms.py Outdated Show resolved Hide resolved
thunder/__init__.py Outdated Show resolved Hide resolved
@t-vi
Copy link
Collaborator

t-vi commented Aug 16, 2024

Could you rebase / resolve the confilicts, please?

t-vi
t-vi reviewed Aug 16, 2024
View reviewed changes
thunder/core/transforms.py Outdated Show resolved Hide resolved
@k223kim k223kim marked this pull request as ready for review August 19, 2024 04:47
t-vi
t-vi approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @k223kim !

@t-vi t-vi merged commit eadda16 into Lightning-AI:main Aug 20, 2024
40 checks passed
@github-actions github-actions bot deleted the k223kim/remove_transform_trace_additionally branch November 19, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees

@t-vi t-vi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transforms as EarlyTransforms
2 participants
@k223kim @t-vi