-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace Transformation Tutorial - CPU Offloading #966
Trace Transformation Tutorial - CPU Offloading #966
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
… trace-transform-tutorial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only a little confused by the helper functions but looks good otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the notebook, it looks really good! Left some minor discussion point questions and clarification / documentation questions, but the code looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Thank you @kshitij12345 @riccardofelluga @crcrpar @Fuzzkatt
One thing I wonder (and I know we're not doing it right in the thunder code either): I think we should require transforms to copy the trace rather than modifying it inplace.
WDYT?
This PR adds a notebook demonstrating writing a transform - in this case a post optimization transform for CPU Offloading