-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DebugTransform - new interface, fixes and doc update. #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crcrpar
reviewed
Aug 16, 2024
Co-authored-by: Masaki Kozuki <mkozuki@nvidia.com>
mruberry
reviewed
Aug 16, 2024
mruberry
reviewed
Aug 16, 2024
lantiga
approved these changes
Aug 19, 2024
riccardofelluga
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, stamping!
… fix-debug-tfms-and-test
…htning-thunder into fix-debug-tfms-and-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro
Output
Problems:
debug_pre_add1
anddebug_pre_mul1
. It should bedebug_pre_add1
anddebug_pre_mul2
otherwise we may have name collision if we had multiple add.header
fordebug_pre_mul1
butdebug_pre_add1
didn't update the captured information.This happens because we capture
pre_debug_bsym
which at the end of the loop refers to the lastpre_debug_bsym
(so essentially all_pre_call_ctx
update the header of the lastpre_debug_bsym
.lightning-thunder/thunder/dev_utils/debug_transform.py
Lines 42 to 49 in 815bff0
Changes:
This PR fixes the above 2 problem and adds a test.
Besides that PR adds a new interface
debug_execution_trace
(open to suggestion for name) function which takes care of adding the transform (this functional interface should be more intuitive as discussed with @riccardofelluga). This PR also adds documentation fordebug_execution_trace
.