-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[benchmark] add option to use torchao's float8 of dynamic scaling with fsdp2 #997
Merged
+120
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drisspg
reviewed
Aug 19, 2024
drisspg
reviewed
Aug 19, 2024
crcrpar
force-pushed
the
crpa/fsdp2-torchao_float8
branch
2 times, most recently
from
August 21, 2024 05:36
a88b136
to
df54b94
Compare
crcrpar
force-pushed
the
crpa/fsdp2-torchao_float8
branch
4 times, most recently
from
August 22, 2024 18:14
e01a625
to
b487ddf
Compare
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
…aling Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
crcrpar
force-pushed
the
crpa/fsdp2-torchao_float8
branch
from
August 23, 2024 01:15
b487ddf
to
3a747cc
Compare
lantiga
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stamped!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to use float8 of torchao.
An example command to use float8 with FSDP2:
note that
--use_torchao_fp8_precompute_scale_for_fsdp true
keeps models in fp32.Llama-2-7b-hf on 8 H100, using pjnl-20240821
as of ff66203, torchao of pytorch/ao@a0376bf
if compiler is torch, fsdp2 is used.