Coerce tensorboard metrics into numpy arrays#21504
Open
pganssle-google wants to merge 15 commits intoLightning-AI:masterfrom
Open
Coerce tensorboard metrics into numpy arrays#21504pganssle-google wants to merge 15 commits intoLightning-AI:masterfrom
pganssle-google wants to merge 15 commits intoLightning-AI:masterfrom
Conversation
As of [Numpy 2.4.0](https://numpy.org/doc/stable/release/2.4.0-notes.html#raise-typeerror-on-attempt-to-convert-array-with-ndim-0-to-scalar), converting an 0-dimensional array to a scalar is now a TypeError, following the expiration of a lengthy deprecation period. This change detects the situation and adjusts the types accordingly before passing them to tensorboard.
pganssle-google
requested review from
ethanwharris,
justusschock,
lantiga,
tchaton and
williamFalcon
as code owners
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21504 +/- ##
=======================================
- Coverage 87% 87% -0%
=======================================
Files 270 270
Lines 23888 23896 +8
=======================================
+ Hits 20665 20671 +6
- Misses 3223 3225 +2 |
deependujha
previously approved these changes
Jan 27, 2026
deependujha
reviewed
Jan 27, 2026
Collaborator
|
seems |
deependujha
reviewed
Mar 19, 2026
deependujha
approved these changes
Mar 19, 2026
deependujha
reviewed
Mar 19, 2026
github-actions
bot
added
docs
justusschock
approved these changes
Mar 19, 2026
deependujha
added
ready to be merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As of Numpy 2.4.0, converting an 0-dimensional array to a scalar is now a TypeError, following the expiration of a lengthy deprecation period.
This change detects the situation and adjusts the types accordingly before passing them to tensorboard.
Fixes #21503
closes #21529
closes #21543
closes #21544
closes #21549
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21504.org.readthedocs.build/en/21504/