change LightningDeprecationWarning to inherit from FutureWarning#21615
Open
knQzx wants to merge 4 commits intoLightning-AI:masterfrom
Open
change LightningDeprecationWarning to inherit from FutureWarning#21615knQzx wants to merge 4 commits intoLightning-AI:masterfrom
knQzx wants to merge 4 commits intoLightning-AI:masterfrom
Conversation
DeprecationWarning is hidden by default in python so end-users never see it. FutureWarning is shown by default which is what we want here since these target end-users not library devs. also removes the now-unnecessary simplefilter override fixes Lightning-AI#11525
knQzx
requested review from
ethanwharris,
justusschock,
lantiga and
tchaton
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21615 +/- ##
=======================================
- Coverage 87% 87% -0%
=======================================
Files 270 270
Lines 23895 23893 -2
=======================================
- Hits 20675 20671 -4
- Misses 3220 3222 +2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeprecationWarning is hidden by default in python so end-users never see these warnings. changed the base class to FutureWarning which is shown by default, and removed the simplefilter override that was only needed because DeprecationWarning was suppressed
fixes #11525
📚 Documentation preview 📚: https://pytorch-lightning--21615.org.readthedocs.build/en/21615/