Skip to content

test: enable testing, and automate execution of tests when PR is opened #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 14, 2024

Conversation

k-capehart
Copy link
Member

@k-capehart k-capehart commented Jun 13, 2024

Tests were not properly running when I ran npm run test so I made a few updates to make it match how it works in core. This includes adding a workflow to automatically run the tests when a PR is opened.

This should enable more unit tests to be created specifically for the sfdx plugin.

@k-capehart k-capehart requested a review from junners June 13, 2024 14:01
@k-capehart
Copy link
Member Author

Oops, I see @nvuillam already submitted a PR with a test workflow. I removed that part so it doesn't conflict but the other changes are still needed in order to run the tests successfully.

@k-capehart
Copy link
Member Author

@junners FYI

@nvuillam
Copy link
Collaborator

@k-capehart it's not a merged PR, mostly because the testing did not work, so if your PR solves it, that's great :)

@junners
Copy link
Member

junners commented Jun 14, 2024

Appreciate the support and contribution @k-capehart ❤️
I've added back the workflow that you've added and added a dummy test for now.
It would be super awesome if we have improved tests on this repo
Was thinking to migrate all mocha tests to jest~ maybe sometime after the release streamlining is done

Copy link
Member

@junners junners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@junners junners merged commit b162a98 into master Jun 14, 2024
1 check passed
@junners junners deleted the enable-testing branch June 14, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants