Lottie-Legacy: migrate to Tuist. #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly cocoapods stuff and examples.
Move files to a different structure, which should be convenient for the future Tuist migration.
To suppress warnings.
Having the product name as an alpha-numeric string with underscores only is a Tuist requirement. This commit contain all the imports changes.
oryonatan
approved these changes
Mar 31, 2025
Comment on lines
+7
to
+10
| name: "Lottie-Legacy", | ||
| destinations: .iOS, | ||
| product: .staticFramework, | ||
| productName: "LottieLegacy", |
Member
There was a problem hiding this comment.
is the name and productName intentionally different?
Member
Author
There was a problem hiding this comment.
It's explained in the PR description why the productName was changed. I can also change the name of the target if we want, but the project is still called Lottie-Legacy.
Member
Author
There was a problem hiding this comment.
I'm not changing it for now, because I don't think it's critical, this is why they are two different params. If you think it's critical I can change it
Notable changes: 1. Remove all unused targets, and have a single, static framework target instead. 2. Rename the product name from Lottie-Legacy to LottieLegacy. This was a Tuist restriction - product name most contain only alpha-numeric chars and underscores.
TamarMilchtaich
force-pushed
the
feature/tuist-migration
branch
from
526ff85 to
520713d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to Tuist. Notable changes: