Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration update for Arbitrum #154

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Configuration update for Arbitrum #154

merged 1 commit into from
Jun 13, 2024

Conversation

arsen3d
Copy link
Contributor

@arsen3d arsen3d commented Jun 11, 2024

  • [X ] Logic - thorough check (from everybody doing review)

Summary

Deployment of Devnet with Arbitrum Nitro as standalone L2.

  • All LP contracts are deployed.
  • All services accounts are funded
  • Output of configuration is visible in the log

Task/Issue reference

https://github.com/Lilypad-Tech/web3/issues/3

How to test this code? (optional)

To redeploy the chain run this workflow:
https://github.com/Lilypad-Tech/lilypad/actions/workflows/devnet_deploy_chain.yml

This will reset the current deployment.

@arsen3d arsen3d force-pushed the arsen/build-devnet branch from b335569 to 544f9c2 Compare June 11, 2024 16:00
@arsen3d arsen3d requested review from AquiGorka and bgins June 11, 2024 16:03
docker/chain/Dockerfile Outdated Show resolved Hide resolved
hardhat/DEPLOYMENT.MD Outdated Show resolved Hide resolved
hardhat/utils/web3.ts Outdated Show resolved Hide resolved
stack Outdated Show resolved Hide resolved
Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arsen3d we need to review your workflow for stacking changes and committing changes when you have more than one PR open.

docker/chain/Dockerfile Outdated Show resolved Hide resolved
@arsen3d arsen3d force-pushed the arsen/build-devnet branch 2 times, most recently from 9432e5e to 2b466d6 Compare June 11, 2024 21:12
@arsen3d arsen3d changed the base branch from main to arsen/build-local-l2-dev June 11, 2024 21:49
Base automatically changed from arsen/build-local-l2-dev to main June 11, 2024 22:05
@arsen3d arsen3d force-pushed the arsen/build-devnet branch 5 times, most recently from be40f26 to 5268b9d Compare June 12, 2024 18:24
@arsen3d arsen3d force-pushed the arsen/build-devnet branch from 5268b9d to 5c998a0 Compare June 12, 2024 18:33
Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🍸 (margarita!)

Thanks @arsen3d !

@@ -34,7 +34,11 @@ const config: HardhatUserConfig = {
chainId: CHAIN_ID,
accounts: [getAccount('admin').privateKey],
},

devnet: {
url: 'http://0.0.0.0:8547',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arsen3d are we sure about this value? cc @bgins

@AquiGorka AquiGorka merged commit 93cc037 into main Jun 13, 2024
3 checks passed
@AquiGorka AquiGorka deleted the arsen/build-devnet branch June 13, 2024 17:44
noryev pushed a commit that referenced this pull request Jun 17, 2024
arsen3d added a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants