Conversation
hunjixin
force-pushed
the
perf/imporve_cuda_speed
branch
from
7bce23b to
d60438d
Compare
richardbremner
approved these changes
Jun 24, 2024
Contributor
richardbremner
left a comment
richardbremner
left a comment
There was a problem hiding this comment.
I don't follow most of the CUDA, but as long as you have tested it and the integration tests pass, go ahead
This was referenced Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Type Requested (choose one):
Summary
Provide a one line summary and link to any relevant references
Task/Issue reference
Closes: add_link_here
Details (optional)
Add any additional details that might help Code Reviewers digest this PR
How to test this code? (optional)
Anything else? (optional)