Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: deploy resource provider #184

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

AquiGorka
Copy link
Contributor

@AquiGorka AquiGorka commented Jun 24, 2024

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)

Summary

These changes add the deploy script for the testnet CPU resource provider (make sure at least there is one RP that can run cowsay)

Task/Issue reference

Closes: #141

Details (optional)

For whatever reason, I could not get this to work with doppler, if I injected the doppler envs as a file for run the private key was not used 🤷 so I went with the approach of adding it to the secrets in github.

How to test this code? (optional)

Tested while I created the PR, if you are reading this, I've already made sure the deploy works and we already have an instance in AWS and I was looking at the solver logs and can verify this deploy incremented the number of resource offers (7 at this time)

@github-actions github-actions bot added the build label Jun 24, 2024
@AquiGorka AquiGorka force-pushed the gorka/build-deploy-resource-provider branch 15 times, most recently from 3d295c5 to f68a974 Compare June 24, 2024 19:06
@AquiGorka AquiGorka force-pushed the gorka/build-deploy-resource-provider branch 2 times, most recently from 048a0e7 to 8bcf544 Compare June 24, 2024 19:15
Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@AquiGorka AquiGorka merged commit 210da18 into main Jun 24, 2024
1 check passed
@AquiGorka AquiGorka deleted the gorka/build-deploy-resource-provider branch June 24, 2024 19:44
bgins pushed a commit that referenced this pull request Jun 25, 2024
* build: add job for deploying rp

* fix: resource provider dockerfile lilypad service run in background
Copy link
Contributor

@noryev noryev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm- awesome update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Add a resource provider vm instance for us to be able to run cowsay jobs
3 participants